Remove fmts and subs temporary value

Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>

yt_dlp/extractor/orf.py

@@ -12,7 +12,6 @@ from ..utils import (
     int_or_none,
     join_nonempty,
     make_archive_id,
-    merge_dicts,
     mimetype2ext,
     orderedSet,
     remove_end,
@@ -581,57 +580,53 @@ class ORFONIE(InfoExtractor):
             'title': 'School of Champions (4/8)',
             'description': 'md5:d09ad279fc2e8502611e7648484b6afd',
             'media_type': 'episode',
+            'timestamp': 1706472362,
+            'upload_date': '20240128',
         }
     }]
 
-    def _call_api(self, video_id, display_id):
-        # NOTE: the prefix `3dSlfek03nsLKdj4Jsd` is only based on my observation on several
-        # api call. This string may change in future
+    def _extract_video(self, video_id, display_id):
         encrypted_id = base64.b64encode(f'3dSlfek03nsLKdj4Jsd{video_id}'.encode()).decode()
         api_json = self._download_json(
             f'https://api-tvthek.orf.at/api/v4.3/public/episode/encrypted/{encrypted_id}', display_id)
 
         formats, subtitles = [], {}
-        for manifest_type in api_json.get('sources') or [{}]:
-            for manifest_info in traverse_obj(api_json, ('sources', manifest_type, ...)):
-                fmt, subs = [], {}
+        for manifest_type in traverse_obj(api_json, ('sources', {dict.keys}, ...)):
+            for manifest_url in traverse_obj(api_json, ('sources', manifest_type, ..., 'src', {url_or_none})):
                 if manifest_type == 'hls':
-                    fmt, subs = self._extract_m3u8_formats_and_subtitles(manifest_info.get('src'), display_id)
+                    fmts, subs = self._extract_m3u8_formats_and_subtitles(
+                        manifest_url, display_id, fatal=False, m3u8_id='hls')
                 elif manifest_type == 'dash':
-                    fmt, subs = self._extract_mpd_formats_and_subtitles(manifest_info.get('src'), display_id, fatal=False)
+                    fmts, subs = self._extract_mpd_formats_and_subtitles(
+                        manifest_url, display_id, fatal=False, mpd_id='dash')
                 else:
                     continue
-                formats.extend(fmt)
+                formats.extend(fmts)
                 self._merge_subtitles(subs, target=subtitles)
 
         return {
-            'id': video_id or api_json.get('id'),
+            'id': video_id,
             'formats': formats,
             'subtitles': subtitles,
             **traverse_obj(api_json, {
-                'duration': ('duration_second', float_or_none),
-                'title': (('title'), ('headline')),
-                'description': (('description'), ('teaser_text')),
-                'media_type': 'video_type'
-            })
+                'duration': ('duration_second', {float_or_none}),
+                'title': (('title', 'headline'), {str}),
+                'description': (('description', 'teaser_text'), {str}),
+                'media_type': ('video_type', {str}),
+            }, get_all=False)
         }
 
     def _real_extract(self, url):
         video_id, display_id = self._match_valid_url(url).group('id', 'slug')
         webpage = self._download_webpage(url, display_id)
-        json_ld_data = self._search_json_ld(webpage, display_id)
+        json_ld_data = self._search_json_ld(webpage, display_id, fatal=False)
 
-        api_data = self._call_api(video_id, display_id)
-
-        return merge_dicts(api_data, {
+        return {
             'id': video_id,
             'title': (json_ld_data.get('title')
                       or self._html_search_meta(['og:title', 'twitter:title'], webpage)),
             'description': (json_ld_data.get('description')
                             or self._html_search_meta(['description', 'og:description', 'twitter:description'], webpage)),
-            **traverse_obj(json_ld_data, {
-                'duration': ('duration', {float_or_none}),
-                'timestamp': ('timestamp', int_or_none),
-                'thumbnails': 'thumbnails'
-            })
-        })
+            **json_ld_data,
+            **self._extract_video(video_id, display_id)
+        }