Sceptique/MetalAdventures
Sceptique/MetalAdventures
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dev/wip_excel_parsing #1

Merged
Sceptique merged 14 commits from dev/wip_excel_parsing into master 2022-09-24 23:21:18 +02:00
Conversation 1 Commits 14 Files Changed 4 +40
Neph commented 2022-09-20 00:10:48 +02:00
Collaborator
Copy Link

WOOP
WOOP
ASSASSIN DE LA POLICE

WOOP WOOP ASSASSIN DE LA POLICE
Neph added 2 commits 2022-09-20 00:10:50 +02:00
Neph added 1 commit 2022-09-20 00:12:11 +02:00
Sceptique reviewed 2022-09-20 09:08:52 +02:00
src/metal_adventures/character/readexcel.rb Outdated
@ -0,0 +1,26 @@
require 'roo'
Sceptique commented 2022-09-20 09:08:52 +02:00
Owner
Copy Link

Il faut renommer le fichier: on essaie d'avoir une structure isomorphique (code avec le même nommage que la structure de fichier)

metal_aventures/character/import_neph_sheet.rb => MetalAdventures::Character::ImportNephSheet

Il faut renommer le fichier: on essaie d'avoir une structure isomorphique (code avec le même nommage que la structure de fichier) metal_aventures/character/import_neph_sheet.rb => MetalAdventures::Character::ImportNephSheet
Neph marked this conversation as resolved
Sceptique reviewed 2022-09-20 09:09:24 +02:00
src/metal_adventures/character/readexcel.rb Outdated
@ -0,0 +3,4 @@
module MetalAdventures
class Character
module ImportNephSheet
def self.import(path:)
Sceptique commented 2022-09-20 09:09:24 +02:00
Owner
Copy Link

La fonction devrait retourner le nouveau personnage

La fonction devrait retourner le nouveau personnage
Sceptique marked this conversation as resolved
Sceptique reviewed 2022-09-20 09:09:41 +02:00
src/metal_adventures/character/readexcel.rb Outdated
@ -0,0 +6,4 @@
def self.import(path:)
xls = Roo::Spreadsheet.open(path, extension: :xlsx)
test = Character.new(name: xls.sheet(0).b3).save
Sceptique commented 2022-09-20 09:09:40 +02:00
Owner
Copy Link

on renomme la variable test pour un vrai truc ? :D

on renomme la variable test pour un vrai truc ? :D
Sceptique marked this conversation as resolved
Sceptique commented 2022-09-20 09:11:13 +02:00
Owner
Copy Link

T'as oublié de gitignore le dossier temp.

Je pense qu'on peut garder clap.xlsx mais il faudrait l'utiliser pour faire des tests unitaires pour vérifier que le code continue de marcher dans le futur.

T'as oublié de gitignore le dossier temp. Je pense qu'on peut garder clap.xlsx mais il faudrait l'utiliser pour faire des tests unitaires pour vérifier que le code continue de marcher dans le futur.
Neph added 1 commit 2022-09-21 23:39:13 +02:00
Neph added 1 commit 2022-09-22 21:18:03 +02:00
Neph added 6 commits 2022-09-22 21:26:09 +02:00
Sceptique reviewed 2022-09-23 00:29:08 +02:00
src/metal_adventures/character/ImportNephSheet.rb Outdated
@ -0,0 +6,4 @@
def self.import(path:)
xls = Roo::Spreadsheet.open(path, extension: :xlsx)
newCharacter = Character.new(name: xls.sheet(0).b3).save
Sceptique commented 2022-09-23 00:29:08 +02:00
Owner
Copy Link

le standard dit que les variables sont en snake_case

le standard dit que les variables sont en snake_case
Sceptique commented 2022-09-24 19:53:45 +02:00
Owner
Copy Link
-         newCharacter = Character.new(name: xls.sheet(0).b3).save
+         new_character = Character.new(name: xls.sheet(0).b3).save
```patch - newCharacter = Character.new(name: xls.sheet(0).b3).save + new_character = Character.new(name: xls.sheet(0).b3).save ```
Neph marked this conversation as resolved
Sceptique reviewed 2022-09-23 00:29:23 +02:00
src/metal_adventures/character/ImportNephSheet.rb Outdated
@ -0,0 +1,29 @@
require 'roo'
Sceptique commented 2022-09-23 00:29:23 +02:00
Owner
Copy Link

nom de fichier en snake_case

nom de fichier en snake_case
Neph marked this conversation as resolved
Sceptique reviewed 2022-09-23 00:29:24 +02:00
src/metal_adventures/character/ImportNephSheet.rb Outdated
@ -0,0 +1,29 @@
require 'roo'
Sceptique commented 2022-09-23 00:29:24 +02:00
Owner
Copy Link

nom de fichier en snake_case

nom de fichier en snake_case
Neph marked this conversation as resolved
Sceptique reviewed 2022-09-24 19:52:47 +02:00
.gitignore Outdated
@ -3,3 +3,5 @@
doc/
.yardoc/
help
temp/*
Sceptique commented 2022-09-24 19:52:46 +02:00
Owner
Copy Link

temp/ should suffice

temp/ should suffice
Neph marked this conversation as resolved
Neph added 1 commit 2022-09-24 21:34:40 +02:00
Neph added 2 commits 2022-09-24 21:40:10 +02:00
Sceptique merged commit b1439c7300 into master 2022-09-24 23:21:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sceptique/MetalAdventures#1
No description provided.
Delete Branch "dev/wip_excel_parsing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?